Fix for API changes in Hummingbird 0.1.0 #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Interlandi <mainterl@microsoft.com>
Signed-off-by: Matteo Interlandi <mainterl@microsoft.com>
|
I pinned Hummingbird to version 0.0.6 (the current version) instead of changing the API. |
interesaaat
changed the title
|
@wenbingl we are going to push the new Hummingbird release today. In case your nightly breaks, this PR will fix it. |
wenbingl
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the next release of Hummingbird we will deprecate the ability to pass input types to the converter. This PR makes sure that the the lightGBM converter will work with the new Hummingbird API.