Enable option zipmap for LGBM converter (fix issue #451) #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
|
This pull request introduces 1 alert when merging 23bb91d into 331df2e - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 5aae251 into 331df2e - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 437813c into 331df2e - view on LGTM.com new alerts:
|
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
xadupre
changed the title
|
What happens on this PR? I saw the big changes on every files. How do you suppose I can review the change? |
|
Sorry for that. I forgot to check the end of line. I wonder if there is a way to add a unit test checking that. I'll change that. |
|
It looks better now. |
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
wenbingl
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.