Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #457, use all tree when best_ntree_limit is not specified #459

Merged
merged 19 commits into from
May 24, 2021
Merged

Fixes #457, use all tree when best_ntree_limit is not specified #459

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
e6895c7
Test onnxmltools against Python3.8
sdpython Apr 15, 2021
824830d
Fix #457, issue with empty tree
sdpython Apr 15, 2021
80c953a
fix import issue with latest version of libsvm
sdpython Apr 15, 2021
e5e92cd
Merge branch 'ci18' of https://github.com/xadupre/onnxmltools into xg…
sdpython Apr 15, 2021
fb4e375
update import
sdpython Apr 15, 2021
3b04f35
ci
sdpython Apr 15, 2021
a1f22c1
fix svm issue
sdpython Apr 15, 2021
763b680
update build
sdpython Apr 15, 2021
4ac817b
ci
sdpython Apr 15, 2021
651bb0c
disable one test
sdpython Apr 15, 2021
57f0568
disable on test on keras2onnx
sdpython Apr 15, 2021
75c538e
Merge branch 'ci18' of https://github.com/xadupre/onnxmltools into xg…
sdpython Apr 15, 2021
87beebc
cath anotehr exception
sdpython Apr 16, 2021
d6e933d
Merge branch 'ci18' of https://github.com/xadupre/onnxmltools into xg…
sdpython Apr 16, 2021
157f008
fix eol
sdpython Apr 21, 2021
765d0df
Merge branch 'ci18' of https://github.com/xadupre/onnxmltools into xg…
sdpython Apr 21, 2021
bced5f6
fix eol
sdpython Apr 21, 2021
a4624fc
Merge branch 'master' of https://github.com/onnx/onnxmltools into xgb…
sdpython Apr 22, 2021
bc37917
Merge branch 'master' into xgbempty
wenbingl May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion onnxmltools/convert/xgboost/operator_converters/XGBoost.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def convert(scope, operator, container):

bst = xgb_node.get_booster()
best_ntree_limit = getattr(bst, 'best_ntree_limit', len(js_trees)) * ncl
if best_ntree_limit < len(js_trees):
if 0 < best_ntree_limit < len(js_trees):
js_trees = js_trees[:best_ntree_limit]
attr_pairs = XGBClassifierConverter._get_default_tree_attribute_pairs()
XGBConverter.fill_tree_attributes(js_trees, attr_pairs, [1 for _ in js_trees], True)
Expand Down
Loading