add node to container instead of changing output node of container #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Benedikt Jagusch <jan.jagusch@gmail.com>
janjagusch
force-pushed
the
fix-custom-post-transform-nodes-3
branch
from
c1fbebc to
aab08a2
Compare
Signed-off-by: Jan-Benedikt Jagusch <jan.jagusch@gmail.com>
janjagusch
force-pushed
the
fix-custom-post-transform-nodes-3
branch
from
8195092 to
178370c
Compare
xadupre
approved these changes
Jul 13, 2021
|
@xadupre thanks for approving! could you also merge it, please? 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
In #463 I added a bug (sorry about that!) by changing that output node of the container. This is a really bad idea and can lead to strange side effects where this node will remain a container output, even after adding more nodes that use it as input.
Generally I believe it's much safer to use the
container.add_nodefunction instead, which is what I'm doing in this PR.