Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves lightgbm conversion speed #491

Merged
merged 9 commits into from
Aug 20, 2021
Merged

Improves lightgbm conversion speed #491

merged 9 commits into from
Aug 20, 2021

Conversation

xadupre
Copy link
Collaborator

@xadupre xadupre commented Aug 18, 2021

Conversion speed up for lightgbm model. For a big model (~40000 trees), the conversion goes from 3 hours to 10 minutes for lightgbm. Fixes #482.

Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Aug 18, 2021

This pull request introduces 1 alert and fixes 3 when merging ce75d85 into cf660f0 - view on LGTM.com

new alerts:

  • 1 for Non-callable called

fixed alerts:

  • 3 for Use of the return value of a procedure

Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Aug 18, 2021

This pull request fixes 3 alerts when merging b099fe3 into cf660f0 - view on LGTM.com

fixed alerts:

  • 3 for Use of the return value of a procedure

Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Aug 19, 2021

This pull request fixes 3 alerts when merging fe48e76 into cf660f0 - view on LGTM.com

fixed alerts:

  • 3 for Use of the return value of a procedure

@lgtm-com
Copy link

lgtm-com bot commented Aug 19, 2021

This pull request fixes 3 alerts when merging 6df0b37 into c1651b1 - view on LGTM.com

fixed alerts:

  • 3 for Use of the return value of a procedure

@lgtm-com
Copy link

lgtm-com bot commented Aug 20, 2021

This pull request fixes 3 alerts when merging c97834e into 3d81a0a - view on LGTM.com

fixed alerts:

  • 3 for Use of the return value of a procedure

@xadupre xadupre merged commit cb2782b into onnx:master Aug 20, 2021
@abhishek9804
Copy link

can anyone tell me why i am getting below error on python 3.8, during lightgbm model.
dump_booster_model
ret = json.loads(string_buffer.value.decode('utf-8'), cls=Hook,
TypeError: json_loads_mock() got an unexpected keyword argument 'cls'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert_lightgbm appears to be stuck in an infinite loop for a multiclass model
3 participants