Add check for base_score in _get_attributes function (replace #626) #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o float Signed-off-by: Donald Tolley <tolleybot@gmail.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
xadupre
added a commit
that referenced
this pull request
Oct 2, 2023
* Check if base_score is available and it is a string type convert it to float (#637) Signed-off-by: Donald Tolley <tolleybot@gmail.com> Signed-off-by: Xavier Dupre <xadupre@microsoft.com> Co-authored-by: Donald Tolley <tolleybot@gmail.com> Signed-off-by: James Cao <james.cao@ironwoodcyber.com> * signed (#639) Signed-off-by: Xavier Dupre <xadupre@microsoft.com> Signed-off-by: James Cao <james.cao@ironwoodcyber.com> * Bump ONNX 1.14.1 in CI pipelines (#644) * verify onnx 1.14.1 rc2 Signed-off-by: jcwchen <jacky82226@gmail.com> * Bump ONNX 1.14.1 Signed-off-by: jcwchen <jacky82226@gmail.com> --------- Signed-off-by: jcwchen <jacky82226@gmail.com> Signed-off-by: James Cao <james.cao@ironwoodcyber.com> * fix (dev): Working start to address issue #648. This will help enable saving and reading of models from Spark, a requirement for GBTClassifier tree conversion Signed-off-by: James Cao <james.cao@ironwoodcyber.com> * feat: Allow conversions of SparkML models to ONNX using cluster mode Signed-off-by: James Cao <james.cao@ironwoodcyber.com> * fix: fix bug that did not fully create temp paths Signed-off-by: James Cao <james.cao@ironwoodcyber.com> * fix: reformat style Signed-off-by: James Cao <james.cao@ironwoodcyber.com> * fix: Fixed formatting style to pass ruff tests Signed-off-by: James Cao <james.cao@ironwoodcyber.com> --------- Signed-off-by: Donald Tolley <tolleybot@gmail.com> Signed-off-by: Xavier Dupre <xadupre@microsoft.com> Signed-off-by: James Cao <james.cao@ironwoodcyber.com> Signed-off-by: jcwchen <jacky82226@gmail.com> Co-authored-by: Xavier Dupré <xadupre@users.noreply.github.com> Co-authored-by: Donald Tolley <tolleybot@gmail.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.