Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor with black #1009

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Refactor with black #1009

merged 5 commits into from
Aug 1, 2023

Conversation

xadupre
Copy link
Collaborator

@xadupre xadupre commented Jul 27, 2023

black became the standard.

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@xadupre xadupre requested a review from xiaowuhu July 27, 2023 21:16
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
@xadupre xadupre merged commit 8a4a803 into onnx:main Aug 1, 2023
32 checks passed
xadupre added a commit to xadupre/sklearn-onnx that referenced this pull request Aug 1, 2023
* Refactor with black

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>

* remove unnecessary skip condition

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>

* freeze lightgbm version

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>

* add ruff to github action

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>

* update badge on README.md

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>

---------

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
xadupre added a commit that referenced this pull request Aug 1, 2023
* Fix converter for DecisionTreeClassifier if n_classses == 1

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>

* list or np.array

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>

* lint

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>

* froze lightgbm version

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>

* black

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>

* Refactor with black (#1009)

* Refactor with black

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>

* remove unnecessary skip condition

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>

* freeze lightgbm version

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>

* add ruff to github action

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>

* update badge on README.md

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>

---------

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>

* fix old CI

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>

---------

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupré <xadupre@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant