Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes class OnnxSubOperator, refactoring of class OnnxOperator #631

Merged
merged 48 commits into from
Apr 29, 2021
Merged

Removes class OnnxSubOperator, refactoring of class OnnxOperator #631

merged 48 commits into from
Apr 29, 2021

Conversation

xadupre
Copy link
Collaborator

@xadupre xadupre commented Mar 20, 2021 •
edited
Loading

OnnxSubEstimator and OnnxSubOperator can be used for the same purpose. The second one is marked as deprecated. Remove use of hasattr in OnnxOperator, make sure method OnnxOperator.to_onnx works as function to_onnx.

@sdpython
Add MANIFEST.in
1c4cbd3 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@sdpython
rebase
3a2f01b 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@sdpython
improve conversion
43bc9e5 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@xadupre xadupre added bug Something isn't working Agility labels Mar 20, 2021
@sdpython
add unit test to check the modification
adac708 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@sdpython
fix one type issue
94fbdbb 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@sdpython
modifies all shape calculator
0dd9a23 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@sdpython
implements get_first_dimension
6a6d77a 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@sdpython
modifies all shape calculator
7f4cbe2 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@sdpython
modifies all shape calculator
553152c 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@sdpython
handle multiple results
a195948 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@sdpython
eol
5dadef0 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@sdpython
refactoring
c5dc3d9 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Mar 23, 2021

This pull request fixes 2 alerts when merging c5dc3d9 into a8267e7 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@sdpython
fix inputs, outputs
8b55ff5 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Mar 23, 2021

This pull request fixes 2 alerts when merging 8b55ff5 into a8267e7 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@sdpython
refactoring again
19f765e 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Mar 23, 2021

This pull request fixes 2 alerts when merging 19f765e into a8267e7 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@sdpython
refactoring
b0d5824 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Mar 23, 2021

This pull request fixes 2 alerts when merging b0d5824 into a8267e7 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@sdpython
refactoring
0ee73f7 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Mar 24, 2021

This pull request introduces 1 alert and fixes 2 when merging 0ee73f7 into a8267e7 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

fixed alerts:

  • 2 for Unused import

@sdpython
refactoring 6
34e105c 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Mar 24, 2021

This pull request introduces 1 alert and fixes 2 when merging 34e105c into a8267e7 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

fixed alerts:

  • 2 for Unused import

@sdpython
fix type issue
44c238d 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Mar 24, 2021

This pull request introduces 1 alert and fixes 2 when merging 44c238d into a8267e7 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

fixed alerts:

  • 2 for Unused import

@sdpython
fix example
40c8bdb 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Mar 24, 2021

This pull request introduces 1 alert and fixes 2 when merging 40c8bdb into a8267e7 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

fixed alerts:

  • 2 for Unused import

@sdpython
decimal
97e1874 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Mar 25, 2021

This pull request fixes 2 alerts when merging 97e1874 into a8267e7 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@sdpython
ut
efc28c5 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Mar 25, 2021

This pull request fixes 2 alerts when merging efc28c5 into a8267e7 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@sdpython
better error message
74701bb 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Mar 27, 2021

This pull request fixes 2 alerts when merging 74701bb into a8267e7 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@sdpython
Deprecate OnnxSubOperator
28f0282 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Mar 31, 2021

This pull request fixes 2 alerts when merging 28f0282 into a8267e7 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@sdpython
merge
8fafc13 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Apr 2, 2021

This pull request fixes 2 alerts when merging 8fafc13 into b612557 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@sdpython
add missing import
d53c2db 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Apr 4, 2021

This pull request fixes 2 alerts when merging d53c2db into b612557 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@sdpython
improve deprecation test
7aff2ff 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Apr 6, 2021

This pull request fixes 2 alerts when merging 7aff2ff into b612557 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@sdpython
add missing types
6a5899b 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Apr 6, 2021

This pull request fixes 2 alerts when merging 6a5899b into b612557 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Apr 8, 2021

This pull request fixes 2 alerts when merging 63a85cf into d77efd1 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@sdpython
Merge branch 'master' of https://github.com/onnx/sklearn-onnx into alg
d8f22ba
@sdpython
remove some verification on shapes
5bf2ca0 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@sdpython
add one mor get_first_dimension
441509c 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Apr 16, 2021

This pull request introduces 1 alert and fixes 2 when merging 441509c into 338d0d6 - view on LGTM.com

new alerts:

  • 1 for Suspicious unused loop iteration variable

fixed alerts:

  • 2 for Unused import

@sdpython
fix a bug in concat about types
076a8cf 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Apr 17, 2021

This pull request introduces 1 alert and fixes 2 when merging 076a8cf into 21774f1 - view on LGTM.com

new alerts:

  • 1 for Suspicious unused loop iteration variable

fixed alerts:

  • 2 for Unused import

@sdpython
when shape is unknown
299e806 
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Apr 17, 2021

This pull request introduces 1 alert and fixes 2 when merging 299e806 into 21774f1 - view on LGTM.com

new alerts:

  • 1 for Suspicious unused loop iteration variable

fixed alerts:

  • 2 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Apr 29, 2021

This pull request introduces 1 alert and fixes 2 when merging 9d5b7f5 into 3371d12 - view on LGTM.com

new alerts:

  • 1 for Suspicious unused loop iteration variable

fixed alerts:

  • 2 for Unused import

@xadupre xadupre merged commit ba88251 into onnx:master Apr 29, 2021
@xadupre xadupre deleted the alg branch July 1, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Agility bug Something isn't working Long PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xadupre @sdpython