Modify tfidf_transformer to enable custom vocabulary and approximate sublinear-tf scaling without sparse containers #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adam444555 <a473489548@gmail.com>
Signed-off-by: adam444555 <a473489548@gmail.com>
* Make opset 15 default * fix missing target opset in polynomial features Signed-off-by: adam444555 <a473489548@gmail.com>
Signed-off-by: adam444555 <a473489548@gmail.com>
Signed-off-by: adam444555 <a473489548@gmail.com>
Signed-off-by: adam444555 <a473489548@gmail.com>
Signed-off-by: adam444555 <a473489548@gmail.com>
Signed-off-by: adam444555 <a473489548@gmail.com>
Signed-off-by: adam444555 <a473489548@gmail.com>
…onnx#773) * Update a training value in a failing pipeline used in a unit test * upgrade version Signed-off-by: adam444555 <a473489548@gmail.com>
onnx#772) * Enable RandomForestClassifier in converter for CalibrationClassifierCV * remove unused variable Signed-off-by: adam444555 <a473489548@gmail.com>
* Implements option zipmap for MultiOutputClassifier Signed-off-by: adam444555 <a473489548@gmail.com>
fix code length Signed-off-by: adam444555 <a473489548@gmail.com>
adam444555
force-pushed
the
master
branch
2 times, most recently
from
ad9281b
to
3cc1a6f
Compare
xadupre
reviewed
Nov 12, 2021
xadupre
reviewed
Nov 12, 2021
|
#777 (comment): sorry I was not clear enough, I just meant adding something like |
xadupre
approved these changes
Nov 15, 2021
adam444555
force-pushed
the
master
branch
4 times, most recently
from
13edd88
to
2a99400
Compare
Signed-off-by: adam444555 <a473489548@gmail.com>
|
A specific commit could not be signed off (I tried with many approaches but no one worked, and I had no idea why). Therefore I rebase the branch to drop the problemetic commit, and then recommit the same change. |
xadupre
approved these changes
Nov 15, 2021
|
Sorry for the trouble. Let me know if it is ready to be merged. |
Yes, it is ready right now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
stop_words_attribute does not exist if custom vocabulary is provided, resulting in AttributeError. Fix it byhasattrcheck.Approximate the sublinear_tf scaling by: first add all coefficient (included null coefficient) by 1 and then take log, i.e. replace tf with log(1+tf). Null coefficient remains to be 0 after the operation.