The from_tflite() function should accept None as default value of input_names and output_names. #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…empty list for input_names and output_names. Signed-off-by: Jay Zhang <jiz@microsoft.com>
hwangdeyu
reviewed
Jun 14, 2022
Signed-off-by: Jay Zhang <jiz@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting a tflite model to an onnx ModelProto using from_tflite() function, if the output_names argument is not specified, it defaults to an empty list instead of None.
However, in the tf2onnx.tflite_utils.graphs_from_tflite function, if the output_names argument is not None, the output names retrieved automatically by the tf2onnx.tflite_utils.parse_tflite_graph function are overwritten, resulting in a ModelProto with no output which causes a bug.
So the function should not change None to an empty list for both input_names and output_names arguments. This PR fixes this problem. Add related tests as well.
Fix #1963
System information
Signed-off-by: Jay Zhang jiz@microsoft.com