Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transpose split optimize attr when opset >=13 #1996

Merged
merged 3 commits into from
Jul 15, 2022

Conversation

hwangdeyu
Copy link
Contributor

@hwangdeyu hwangdeyu commented Jul 12, 2022

split is an optional input not attr since opset 13.
transpose optimizer should adapt to ONNX version >= 13 simultaneously.

fixes #1941

Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
@hwangdeyu hwangdeyu changed the title Fix transpose split optimize when opset >=13 Fix transpose split optimize attr when opset >=13 Jul 12, 2022
Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
Copy link
Collaborator

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
@hwangdeyu hwangdeyu enabled auto-merge (squash) July 15, 2022 06:02
@hwangdeyu hwangdeyu merged commit e896723 into onnx:main Jul 15, 2022
@hwangdeyu hwangdeyu deleted the transpose_optimize branch July 18, 2022 06:07
hwangdeyu added a commit to hwangdeyu/tensorflow-onnx that referenced this pull request Jul 18, 2022
* add tranposeOptimizer split for opset >= 13

Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
Co-authored-by: Guenther Schmuelling <guschmue@microsoft.com>

* add test

Signed-off-by: Deyu Huang <deyhuang@microsoft.com>

* fix comments

Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using TransposeOptimizer breaks model with split optimizer opset >= 13 error
2 participants