Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Select op with Mul inf input to nan error #2035

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

hwangdeyu
Copy link
Contributor

fixes #1988
Signed-off-by: Deyu Huang deyhuang@microsoft.com

Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
Co-authored-by: Jay Zhang <jiz@microsoft.com>
Copy link
Collaborator

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hwangdeyu hwangdeyu merged commit ee09669 into onnx:main Sep 14, 2022
@hwangdeyu hwangdeyu deleted the select_non branch September 14, 2022 06:23
fatcat-z added a commit that referenced this pull request Sep 21, 2022
* fix select mul inf to nan error

Signed-off-by: Deyu Huang <deyhuang@microsoft.com>

* fix pylint

Signed-off-by: Deyu Huang <deyhuang@microsoft.com>

* add break condition

Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
Co-authored-by: Jay Zhang <jiz@microsoft.com>
Signed-off-by: Jay Zhang <jiz@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

got nan output from converted model
2 participants