Fix Infinite Loop in constant folding #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyasher
force-pushed
the
dev-ilyasher-constant-folding-infinite-loop
branch
3 times, most recently
from
75ff402
to
06d2b24
Compare
This commit fixes a bug in the function compute_const_folding_using_tf where an already-folded StridedSlice node could set the 'update' flag to True, causing an infinite loop. A regression test was also added. The test checks for the infinite loop by setting a timeout using the timeout-decorator module from pypi. Signed-off-by: Ilya Sherstyuk <isherstyuk@nvidia.com>
ilyasher
force-pushed
the
dev-ilyasher-constant-folding-infinite-loop
branch
from
06d2b24
to
2014b6e
Compare
|
@fatcat-z Could you please review when you get the chance? Thanks! |
fatcat-z
approved these changes
Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in the function compute_const_folding_using_tf where an already-folded StridedSlice node could set the 'update' flag to True, causing an infinite loop.
A regression test was also added. The test checks for the infinite loop by setting a timeout using the timeout-decorator module from pypi.
This should fix issues #2068 and #1965 .