Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for more TensorScatter* operations #2179

Merged
merged 5 commits into from
May 29, 2023

Conversation

javidcf
Copy link
Contributor

@javidcf javidcf commented May 24, 2023

Added support for TensorScatterMax, TensorScatterMin and TensorScatterSub.

Added tests for all TensorScatter* operations.

Added support for TensorScatterMax, TensorScatterMin and
TensorScatterSub.

Added tests for all TensorScatter* operations.

Signed-off-by: Javier Dehesa <javidcf@gmail.com>
Signed-off-by: Javier Dehesa <javidcf@gmail.com>
tests/test_backend.py Outdated Show resolved Hide resolved
tests/test_backend.py Outdated Show resolved Hide resolved
tf.tensor_scatter_nd_update and tf.tensor_scatter_nd_add already tested
elsewhere.

Signed-off-by: Javier Dehesa <javidcf@gmail.com>
Signed-off-by: Javier Dehesa <javidcf@gmail.com>
Signed-off-by: Javier Dehesa <javidcf@gmail.com>
@javidcf
Copy link
Contributor Author

javidcf commented May 27, 2023

Seems there was some issue with Azure in the failing checks above. Can those be retried @fatcat-z ?

Copy link
Collaborator

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contributions!

@fatcat-z fatcat-z merged commit 256dd5c into onnx:main May 29, 2023
@javidcf javidcf deleted the support_tensorscattersub branch May 31, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants