Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bitwise ops #2192

Merged
merged 7 commits into from
Jul 4, 2023
Merged

Support bitwise ops #2192

merged 7 commits into from
Jul 4, 2023

Conversation

f-salvetti
Copy link
Contributor

Support the following bitwise ops with ONNX opset 18:

  • tf.bitwise.bitwise_and
  • tf.bitwise.bitwise_or
  • tf.bitwise.bitwise_xor
  • tf.bitwise.invert

Signed-off-by: Salvetti, Francesco <francesco.salvetti@nuance.com>
Signed-off-by: Salvetti, Francesco <francesco.salvetti@nuance.com>
Signed-off-by: Salvetti, Francesco <francesco.salvetti@nuance.com>
Signed-off-by: Salvetti, Francesco <francesco.salvetti@nuance.com>
@fatcat-z
Copy link
Collaborator

fatcat-z commented Jul 2, 2023

Thanks for your contributions!

Please also update support_status.md to add these great ops as well, thank you!

Signed-off-by: Salvetti, Francesco <francesco.salvetti@nuance.com>
Copy link
Collaborator

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fatcat-z
Copy link
Collaborator

fatcat-z commented Jul 3, 2023

The failure in pretrained_model_test has no relationship to your PR. I will submit another PR to resolve that issue. After that, we will sync and merge this PR.

Use LANCZOS instead.

Signed-off-by: Jay Zhang <jiz@microsoft.com>
@fatcat-z
Copy link
Collaborator

fatcat-z commented Jul 4, 2023

Could you please merge the change in this PR into your PR so I can approve the whole change?

@fatcat-z fatcat-z enabled auto-merge (squash) July 4, 2023 08:43
@fatcat-z fatcat-z merged commit 25c977c into onnx:main Jul 4, 2023
@f-salvetti f-salvetti deleted the support-bitwise-ops branch July 4, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants