Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Monitor on/off should not be part of State #206

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

jeremyfowers
Copy link
Collaborator

The build monitor on/off setting was a member of State out of convenience, however this can cause some crazy behavior when the monitor setting is applied on one machine and then unintentionally loaded as state on another machine.

@jeremyfowers jeremyfowers added the bug Something isn't working label Jul 24, 2024
@jeremyfowers jeremyfowers self-assigned this Jul 24, 2024
Copy link
Collaborator

@ramkrishna2910 ramkrishna2910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jeremyfowers jeremyfowers merged commit abe694a into main Jul 24, 2024
6 checks passed
@jeremyfowers jeremyfowers deleted the bug/monitor branch July 24, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants