Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move run submodule out into the new devices plugin #222

Merged
merged 23 commits into from
Aug 27, 2024
Merged

Conversation

jeremyfowers
Copy link
Collaborator

@jeremyfowers jeremyfowers commented Aug 23, 2024

This PR moves the contents of turnkeyml.run into an optional plugin called turnkeyml_plugin_devices. That plugin must be installed to gain access to the benchmark Tool.

Design notes:

  • A new test, benchmark.py, is introduced, however it requires that turnkeyml>=4.0.0 be released before it can run. So, we will enable that in a follow-up PR. A lot of the cli.py tests moved in there.
  • The example_combined and example_rt example plugins have been removed because, now, they were just essentially examples of how to add content to turnkeyml_plugin_devices. That seemed really unnecessary since turnkeyml_plugin_devices has 3 self-contained examples of how to add content (onnxrt, torchrt, tensorrt).

@jeremyfowers jeremyfowers self-assigned this Aug 23, 2024
@jeremyfowers jeremyfowers marked this pull request as ready for review August 27, 2024 14:21
@jeremyfowers jeremyfowers changed the title Refresh5 Move run submodule out into the new devices plugin Aug 27, 2024
Copy link
Collaborator

@danielholanda danielholanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only added a few non-blocking suggestions.

setup.py Show resolved Hide resolved
src/turnkeyml/version.py Outdated Show resolved Hide resolved
plugins/devices/README.md Show resolved Hide resolved
Signed-off-by: Jeremy Fowers <80718789+jeremyfowers@users.noreply.github.com>
Signed-off-by: Jeremy Fowers <80718789+jeremyfowers@users.noreply.github.com>
Signed-off-by: Jeremy Fowers <80718789+jeremyfowers@users.noreply.github.com>
@jeremyfowers jeremyfowers enabled auto-merge (squash) August 27, 2024 21:19
@jeremyfowers jeremyfowers merged commit 37f5e8d into main Aug 27, 2024
6 checks passed
@jeremyfowers jeremyfowers deleted the refresh5 branch August 27, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants