window might not be defined in node.js environment. #156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I was trying to do server-side rendering of my React project, using
metismenu
.It was a success, except by one problem: currently
metismenu
assumes thatwindow
object is available, while checking forwindow.QUnit
object in tests. Thing is, in node.js environmentwindow
isundefined
, thus this code is crashing.So I did this tiny fix, checking if
window
isundefined
. This will enable the use ofmetismenu
on server side and make me (and hopefully other users) happy campers.Please, bump package version and publish a patched NPM package, if you accept this PR.
Thanks and cheers!