Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed test summary is not showing up in ginkgo 2.1.4 #973

Closed
poojaprasanthi opened this issue May 3, 2022 · 2 comments
Closed

Failed test summary is not showing up in ginkgo 2.1.4 #973

poojaprasanthi opened this issue May 3, 2022 · 2 comments

Comments

@poojaprasanthi
Copy link

poojaprasanthi commented May 3, 2022 •
edited
Loading

I updated the ginkgo version to 2.1.4.

In my older versions - the test run summary used to look like

Summarizing 4 Failures:

[Panic!] MDCTestsForAuthorizationAndPermission [It] DatasetListAndGetAccessWithOwnerQualifier 
/go/src/cd.splunkdev.com/integration-tests/search/lib/common/common.go:554

[Panic!] MDCTestsForAuthorizationAndPermission [It] DatasetListAndGetAccessWithOwnerQualifier 
/go/src/cd.splunkdev.com/integration-tests/search/lib/common/common.go:554

[Panic!] MDCTestsForAuthorizationAndPermission [It] ModulesListAndGetAccessWithOwnerQualifier 
/go/src/cd.splunkdev.com/integration-tests/search/lib/common/common.go:554

[Panic!] MDCTestsForAuthorizationAndPermission [It] ModulesListAndGetAccessWithOwnerQualifier 
/go/src/cd.splunkdev.com/integration-tests/search/lib/common/common.go:554

Ran 45 of 236 Specs in 694.678 seconds
FAIL! -- 43 Passed | 2 Failed | 0 Flaked | 0 Pending | 191 Skipped
--- FAIL: TestTest (694.70s)
FAIL

but after the upgrade , I could not see the summary about failing tests. it only displays last lines:

Ran 41 of 41 Specs in 276.068 seconds
FAIL! -- 40 Passed | 1 Failed | 0 Pending | 0 Skipped
--- FAIL: TestTest (276.07s)
FAIL

Ginkgo ran 2 suites in 4m38.552614585s

There were failures detected in the following suites:
  e2e ./tests/e2e

Test Suite Failed

what flag should I use to see the failed tests summary?

As of now I am using :

ginkgo -v -progress -no-color -slow-spec-threshold=10s -timeout=60m -flake-attempts=2 -focus ModulesAndKnowledgeObjects  tests/...

Also, how should I silence these outputs like

[SynchronizedAfterSuite] PASSED [115.491 seconds]
[SynchronizedAfterSuite]
/Users/pprasanthi/integration/src/cd.splunkdev.com/integration-tests/search/tests/e2e/suite_setup_test.go:42

  Begin Captured GinkgoWriter Output >>
    [SynchronizedAfterSuite] TOP-LEVEL
      /Users/pprasanthi/integration/src/cd.splunkdev.com/integration-tests/search/tests/e2e/suite_setup_test.go:42
    [SynchronizedAfterSuite] TOP-LEVEL
      /Users/pprasanthi/integration/src/cd.splunkdev.com/integration-tests/search/tests/e2e/suite_setup_test.go:42
  << End Captured GinkgoWriter Output
@anandrkskd
Copy link

+1, I am facing the same issue after updating ginkgo to v2, if there is only one failure in the suit it doesn't show up int the test summary, is there a way we can print the test summary at the end of the test run?

@onsi
Copy link
Owner

onsi commented Aug 25, 2022

hey there - sorry for the delay. I'm pushing out a fix for this now. should cut a release sometime next week or so.

@onsi onsi closed this as completed in 5cf23e2 Aug 25, 2022
@anandrkskd anandrkskd mentioned this issue Aug 29, 2022
Closed
Darthmineboy added a commit to Darthmineboy/rabbitmq-stream-go-client that referenced this issue Jul 22, 2024
@Darthmineboy
update ginkgo as test summary is not showing
8f6c4c9 
onsi/ginkgo#973
@Darthmineboy Darthmineboy mentioned this issue Jul 22, 2024
Merged
Gsantomaggio added a commit to rabbitmq/rabbitmq-stream-go-client that referenced this issue Jul 24, 2024
@Darthmineboy @Gsantomaggio
Fix flush interval (#338)
34bcc2d 
* test that consumer offset is committed after flush interval

* fix auto commit flush interval not triggered with constant stream of incoming messages

* use time.Since()

* update ginkgo as test summary is not showing

onsi/ginkgo#973

* add test reason with number of messages received

* try up to 50 messages

* fix data race

* tidy

* move resetting messageCountBeforeStorage to cacheStoreOffset()

* fix potential data race with messageCountBeforeStorage when closing consumer

* have increaseMessageCountBeforeStorage() return current messageCountBeforeStorage so that we don't need getMessageCountBeforeStorage() and request the mutex twice

---------

Co-authored-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@onsi @anandrkskd @poojaprasanthi