Fix go vet and drop 1.17 from test matrix

onsi · Oct 24, 2022 · 75c8c70 · 75c8c70
1 parent 237e97d
commit 75c8c70
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -16,7 +16,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        version: [ '1.17', '1.18', '1.19' ]
+        version: [ '1.18', '1.19' ]
     name: Go ${{ matrix.version }}
     steps:
     - uses: actions/setup-go@v3

diff --git a/internal/async_assertion_test.go b/internal/async_assertion_test.go
@@ -1348,7 +1348,6 @@ var _ = Describe("Asynchronous Assertions", func() {
 				}()
 				Eventually(nil).Should(QuickMatcher(func(actual any) (bool, error) {
 					panic("welp")
-					return false, nil
 				}))
 			})
 		})
-Original file line number
+Diff line change
@@ Expand Up / @@ -1348,7 +1348,6 @@ var _ = Describe("Asynchronous Assertions", func() { @@
     				}()
     				Eventually(nil).Should(QuickMatcher(func(actual any) (bool, error) {
     					panic("welp")
-    					return false, nil
     				}))
     			})
     		})
@@ Expand Down @@