Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnforceDefaultTimeoutsWhenUsingContexts cannot be used from users #790

Closed
toshipp opened this issue Oct 31, 2024 · 1 comment · Fixed by #791
Closed

EnforceDefaultTimeoutsWhenUsingContexts cannot be used from users #790

toshipp opened this issue Oct 31, 2024 · 1 comment · Fixed by #791

Comments

@toshipp
Copy link
Contributor

toshipp commented Oct 31, 2024

EnforceDefaultTimeoutsWhenUsingContexts was added in e4c4265, but it was implemented as an internal Gomega method, therefore, we cannot use it.

We should the method in the Gomega interface, and also define the global method.
toshipp added a commit to toshipp/gomega that referenced this issue Oct 31, 2024
@toshipp
Export EnforceDefaultTimeoutsWhenUsingContexts and DisableDefaultTime…
d5872e1 
…outsWhenUsingContext

fix: onsi#790

Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
@toshipp toshipp mentioned this issue Oct 31, 2024
Merged
@onsi
Copy link
Owner

onsi commented Oct 31, 2024

woops! my bad, thanks for catching that and fixing it!

@onsi onsi closed this as completed in #791 Oct 31, 2024
@onsi onsi closed this as completed in ca36da1 Oct 31, 2024
@pohly pohly mentioned this issue Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Export EnforceDefaultTimeoutsWhenUsingContexts and DisableDefaultTime… toshipp/gomega
2 participants
@onsi @toshipp