-
-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on ginkgo v1.16.4 #530
Conversation
I see failures related to go mod failing. Perhaps the Go mod check should only happen with Go 1.18 and all tests can be run on 1.16, 1.17, 1.18. I'm not sure what the policy is for Gomega regarding Go compatibility but 1.16 is actually past end of life anyway. |
@blgm I've added a second commit that changes how tests are executed through github actions:
What do you think about dropping 1.16 testing now that it's end of life? |
Hey @BooleanCat thanks for this! So glad to see this crazy circular dependency finally get broken. I'm good with dropping 1.16 now that 1.18 is out. Do you mind updating the PR with that? |
@onsi Done! |
I can reproduce these failures locally - taking a look now. |
It looks like tests are failing because |
I attempted to use Updating to Go 1.18 may simply incur a breaking change to Gomega here. |
Looks like tests are failing against Go 1.18 without any changes - I'll open a separate issue for this. |
Blocked on #531 |
Fix for Go 1.18 here, will rebase once merged: #532 |
hey @BooleanCat - sorry for the delay. I think this is unblocked now. |
@onsi I've done a cheeky rebase now that it's working with Go 1.18 |
thanks! |
According to the go.sum, gomega depends on
github.com/onsi/ginkgo@v1.16.4
and yet it usesgh.neting.cc/onsi/ginkgo@v2.0.0
.This is trivial to fix now that Go 1.18 has shipped, involving only changing the value of the Go directive to
1.18
and then doing a go mod tidy will remove it.Resolves #529