Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Metadata extraction of erronous values and Agent extraction #154

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented Aug 9, 2024

fix agroportal/project-management#582, this enables again the extraction of Agents and re-enforces the extraction process to not fail if only some of the extracted attributes are not valid, accepting the valid and revoking the invalid.

Changes

  • Update metadata extractor to validate each extracted metadata separately to not crash all the process if only some fields are incorrect (f0ddab8)
  • Update submission extraction test to catch erroneous extracted value (b99d26f)
  • Update the metadata extractor to extract agents (2602532)
  • Add agent extraction unit tests (b956c9c)

@syphax-bouazzouni syphax-bouazzouni changed the title Fix: Metadata extraction of erronous values Fix: Metadata extraction of erronous values and Agent extraction Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.97%. Comparing base (552fbe5) to head (b956c9c).
Report is 1 commits behind head on development.

Files Patch % Lines
..._process/operations/submission_extract_metadata.rb 88.57% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #154      +/-   ##
===============================================
+ Coverage        81.83%   81.97%   +0.14%     
===============================================
  Files              100      100              
  Lines             6616     6635      +19     
===============================================
+ Hits              5414     5439      +25     
+ Misses            1202     1196       -6     
Flag Coverage Δ
unittests 81.97% <88.88%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant