Check for property existance for GetImageResult. #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix npm run build fails due to getImage() return type GetImageResult #364
This issue happens when you are running "astro check".
With the original commands you posted this is not a visible error and will not cause any issues.
However, seems like cloudfront deployment pipeline (might be others as well) is running this command which caused a failure with the deployment process.
NB There is also requirement to install astro/check plugin and the js-yaml package.
Have not added them on this specific PR to avoid too many changes.
Will be happy to add them and submit another PR if this is fine by you :)