-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for temporal cloud #79
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 77.41% 82.08% +4.66%
==========================================
Files 32 75 +43
Lines 1913 6295 +4382
==========================================
+ Hits 1481 5167 +3686
- Misses 432 1128 +696
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This is needed for temporal cloud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The tests are green and I am already running this on the data.ooni.org host. I am going to proceed with merging it. (the red is only the codecov complaining, but the pieces of impacted code are really hard to test, so I am tabling this for the moment) |
* v5.0.0-rc.0: Add simple redirector Tidy up the layout of the analysis viewer Add an observations viewer Get rid of all the dataviz that isn't the analysis visualizer Release/5.0.0 alpha3 (#81) Offset analysis schedule by 6 hours Add support for temporal cloud (#79) fix: support for sorting network_events using transaction_id (#51) Optimize performance of table writers and refactor table model (#74) Improvements related to deployment (#69) Add .codecov file Update jsonl sync example Setup workflow to publish ooni data docs (#73) OONI Pipeline v5 alpha (#64) Fix codecov (#62) Temporal workflows (#61) OONI Data, OONI Pipeline split (#60) Add support for caching netinfodb
Changes:
mk*
commands we haveschedule
andbackfill
commandsThis fixes:
As part of this I am doing also a bit of refactoring of the temporal related code to make this easier.