feat: add ability to trace handshake #65
Triggered via pull request
February 13, 2024 11:39
ainghazal
Status
Failure
Total duration
10m 15s
Artifacts
–
build-refactor.yml
on: pull_request
short-tests
10m 7s
lint
8s
gosec
32s
coverage-threshold
17s
integration
30s
Annotations
1 error and 10 warnings
|
short-tests
Process completed with exit code 1.
|
|
lint:
internal/bytesx/bytesx.go#L115
comment on exported function BytesPadPKCS7 should be of the form "BytesPadPKCS7 ..."
|
|
lint:
internal/bytesx/bytesx.go#L38
comment on exported function GenRandomBytes should be of the form "GenRandomBytes ..."
|
|
lint:
internal/tlssession/tlsbio.go#L75
parameter 'tt' seems to be unused, consider removing or renaming it as _
|
|
lint:
internal/tlssession/tlshandshake.go#L160
parameter 'verifiedChains' seems to be unused, consider removing or renaming it as _
|
|
lint:
internal/tlssession/tlsbio.go#L83
parameter 'tt' seems to be unused, consider removing or renaming it as _
|
|
lint:
internal/tlssession/tlsbio.go#L79
parameter 'tt' seems to be unused, consider removing or renaming it as _
|
|
lint:
internal/session/manager.go#L17
type name will be used as session.SessionNegotiationState by other packages, and that stutters; consider calling this NegotiationState
|
|
lint:
internal/session/manager.go#L200
if block ends with a return statement, so drop this else and outdent its block
|
|
lint:
internal/session/manager.go#L166
comment on exported method Manager.NewACKForPacketIDs should be of the form "NewACKForPacketIDs ..."
|
|
lint:
internal/session/manager.go#L23
comment on exported const S_UNDEF should be of the form "S_UNDEF ..."
|