fix(UNetStack): better compatibility with ooni/probe-cli models #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassosimone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactoring at 45a7aa9 was a bit too aggressive and we have lost some degree of interface level compatibility with ooni/probe-cli. Let's repair this:
Add the
CACertaccessor required by ooni/probe-cli code.While there, also declare the accessor as being part of
UnderlyingNetwork.We have a slight issue with
ServerTLSConfig, which is expected by ooni/probe-cli and now is calledMustNewTLSConfigand, additionally, requires the names for which to generate the certificate. We will solve these issues inside the ooni/probe-cli repository, but let's make sure theUNetStackhas the correct method.Part of ooni/probe#2531