Skip to content
This repository has been archived by the owner on Jun 11, 2018. It is now read-only.

SQL instrumentation can break queries with no arguments in certain edgecases #94

Closed
roncohen opened this issue Feb 10, 2016 · 1 comment
Closed

SQL instrumentation can break queries with no arguments in certain edgecases #94

roncohen opened this issue Feb 10, 2016 · 1 comment
Assignees
@jalvz

Comments

@roncohen
Copy link
Contributor

If a mysql query is made directly to cursor.execute(query) (as opposed to cursor.execute(query, args)) and the query contains % the driver will try to replace it using the format notation resulting in a TypeError: ('not enough arguments for format string').
@roncohen roncohen assigned hmdhk and jalvz and unassigned hmdhk Feb 12, 2016
jalvz pushed a commit that referenced this issue Feb 18, 2016
prevent string interpolation with default empty tuple when contains %…
8dadef7 
…, fixes issue #94
jalvz pushed a commit that referenced this issue Feb 19, 2016
prevent string interpolation with default empty tuple when contains %…
785088e 
… for MySQL, fixes issue #94
jalvz pushed a commit that referenced this issue Feb 19, 2016
prevent string interpolation with default empty tuple when contains %…
3392469 
…, fixes issue #94
jalvz pushed a commit that referenced this issue Feb 19, 2016
prevent string interpolation with default empty tuple when contains %…
40e4bed 
… for MySQL, fixes issue #94
jalvz pushed a commit that referenced this issue Feb 19, 2016
Revert "prevent string interpolation with default empty tuple when co…
5bcae2f 
…ntains % for MySQL, fixes issue #94"

This reverts commit 785088e.
jalvz pushed a commit that referenced this issue Feb 19, 2016
Revert "prevent string interpolation with default empty tuple when co…
c1586f6 
…ntains %, fixes issue #94"

This reverts commit 8dadef7.
@jalvz
Copy link

jalvz commented Feb 22, 2016

Fixed in 3.2.2

@jalvz jalvz closed this as completed Feb 22, 2016
@pyup-bot pyup-bot mentioned this issue Jun 14, 2016
Merged
This was referenced Jul 5, 2016
Closed
Closed
@pyup-bot pyup-bot mentioned this issue Jul 27, 2016
Merged
@pyup-bot pyup-bot mentioned this issue Jan 25, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jalvz jalvz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@roncohen @jalvz @hmdhk