Skip to content
This repository has been archived by the owner on Jun 11, 2018. It is now read-only.

The requests instrumentation swallows exceptions #95

Closed
gcbirzan opened this issue Feb 11, 2016 · 2 comments
Closed

The requests instrumentation swallows exceptions #95

gcbirzan opened this issue Feb 11, 2016 · 2 comments
Assignees
@jalvz

Comments

@gcbirzan
Copy link

If you try to use it with a malformed URL (no schema) the exception becomes:

opbeat/instrumentation/packages/requests.py", line 29, in call
signature += " " + host
TypeError: cannot concatenate 'str' and 'NoneType' objects
@roncohen
Copy link
Contributor

Hi @gcbirzan,

Thank you for the bug report. Much appreciated. I'll take a look.

jalvz pushed a commit that referenced this issue Feb 17, 2016
* fix for #95
78bc98b 
* added test for requests
jalvz pushed a commit that referenced this issue Feb 19, 2016
* fix for #95
118a438 
* added test for requests
@jalvz
Copy link

jalvz commented Feb 22, 2016

Hi @gcbirzan ,

This issue is fixed now in the last version (3.2.2)

Thanks!

@jalvz jalvz closed this as completed Feb 22, 2016
@pyup-bot pyup-bot mentioned this issue Jun 14, 2016
Merged
This was referenced Jul 5, 2016
Closed
Closed
@pyup-bot pyup-bot mentioned this issue Jul 27, 2016
Merged
@pyup-bot pyup-bot mentioned this issue Jan 25, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jalvz jalvz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@roncohen @gcbirzan @jalvz