Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mps audit logs now in order #949

Merged
merged 2 commits into from
Jun 21, 2023
Merged

fix: mps audit logs now in order #949

merged 2 commits into from
Jun 21, 2023

Conversation

zaidusmani26
Copy link
Contributor

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #949 (00ae21a) into main (20558db) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 00ae21a differs from pull request most recent head d46cf9f. Consider uploading reports for the commit d46cf9f to get more accurate results

@@            Coverage Diff             @@
##             main     #949      +/-   ##
==========================================
+ Coverage   94.65%   94.66%   +0.01%     
==========================================
  Files          79       79              
  Lines        3384     3395      +11     
  Branches      575      578       +3     
==========================================
+ Hits         3203     3214      +11     
  Misses        175      175              
  Partials        6        6              
Impacted Files Coverage Δ
src/routes/amt/auditLog.ts 72.00% <100.00%> (+2.21%) ⬆️

@zaidusmani26 zaidusmani26 marked this pull request as ready for review June 13, 2023 22:23
@tim-shockley tim-shockley force-pushed the mpsAudit branch 2 times, most recently from 5ef0276 to d357ab6 Compare June 16, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MPS AuditLog API doesn't return audit records with most recent events first.
2 participants