Don't throttle or debounce if those options are zero #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the custom command to be run once for each path modified in a single event, and resolves open-cli-tools#71.
|
@paulmillr it looks like I'm the third person to attempt implementing this change/bugfix. Can you take a look? It's a pretty simple change. Let me know if you need me to add tests for this. |
sbleon
changed the title
|
tests please yes |
|
Awesome! Thanks, Paul!
I'll see what I can put together for tests.
…On Tue, Nov 5, 2019 at 1:06 AM Paul Miller ***@***.***> wrote:
tests please yes
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/kimmobrunfeldt/chokidar-cli/pull/90?email_source=notifications&email_token=AABQQN5BIPXUMERDLI424NTQSEEN3A5CNFSM4JIZSJ72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDBWKNI#issuecomment-549676341>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABQQN3QKGPXXZGEWIPIXXTQSEEN3ANCNFSM4JIZSJ7Q>
.
|
|
Test for this change is in #93. |
This was referenced Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the custom command to be run once for each path modified in a
single event, and resolves #71.