Add auto colors functionality #296

eliasm307 · 2021-11-19T01:43:57Z

Resolves #279

coveralls · 2021-11-19T01:47:54Z

Coverage remained the same at 100.0% when pulling 7929986 on eliasm307:feat/random-colors into f6a588e on open-cli-tools:main.

paescuj · 2022-06-21T10:02:49Z

@eliasm307 Thanks for this pull request! I've now rebased it on the latest state of the main branch. I've only made the necessary changes required for TypeScript & ESM and otherwise kept the original logic the same. Let's see if @gustavohenke and / or me can find the time to review this pull request soon.

gustavohenke

Overall thought that doesn't belong to one specific line:
What do you @eliasm307 and @paescuj think of --prefix-colors taking a special keyword auto that triggers this behaviour? So that this doesn't require implementing/specifying --color.

E.g. concurrently -c auto,red,auto npm:lint npm:test npm:build generates an auto colour for npm:lint, red for npm:test, and another auto colour for npm:build (but excluding red)

README.md

src/prefix-color-selector.ts

eliasm307 · 2022-06-25T00:22:15Z

@gustavohenke thats an interesting suggestion, I think it could fit some use cases where a user wants partial control of the process colours.

However, for me the motivation for this was that I didn't really mind about the colours, as long as they are different. If other users also don't mind and they are trying to use this to spawn several processes then the command ends up with noise like "auto,auto,auto..." which isn't a good experience imo.

How would you feel about supporting both? So one option of all auto colours or being able to specify colours per process with an option to delegate?

gustavohenke · 2022-06-29T23:39:02Z

command ends up with noise like "auto,auto,auto..." which isn't a good experience imo.

We could rely on the current behaviour of the last input colour getting repeated when there are less colours than commands. So a single auto would do it if you had 20 commands.

Also sorry for reviewing this harshly, I didn't notice it was from a bunch of months back! 😱

paescuj · 2022-06-30T06:31:21Z

We could rely on the current behaviour of the last input colour getting repeated when there are less colours than commands. So a single auto would do it if you had 20 commands.

I've already considered this too.
The advantage to this would be that we don't need to introduce another option.
The disadvantage in my opinion is that it might not be very intuitive at first glance. For example if I want to have auto colors for all commands except the second one, then I had to use auto,red,auto. I think this is okay, but we would need to document it clearly and provide a few examples.

eliasm307 · 2022-07-22T13:43:42Z

command ends up with noise like "auto,auto,auto..." which isn't a good experience imo.

We could rely on the current behaviour of the last input colour getting repeated when there are less colours than commands. So a single auto would do it if you had 20 commands.

Also sorry for reviewing this harshly, I didn't notice it was from a bunch of months back! 😱

@gustavohenke Hey, I didnt think it was harsh, it was good feedback, thanks for taking the time to review it 🙂

eliasm307 · 2022-07-22T14:17:11Z

Example output:

paescuj

Thanks @eliasm307 for your great work here!
It looks good to me 👍
I just did some small enhancements concerning docs & comments and a little cleanup.

Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>

To be consistent with existing code style

This reverts commit f3c1fcf.

…Colors' I'm neither happy with extending expect nor with having expect in a external function, so I'm using 'it.each' to solve this

paescuj · 2022-10-02T14:56:43Z

What do you think @gustavohenke?

gustavohenke

🤦 I had reviewed just hadn't submitted

src/prefix-color-selector.spec.ts

gustavohenke · 2022-10-22T05:53:43Z

Published in v7.5.0!

eliasm307 force-pushed the feat/random-colors branch 2 times, most recently from c9739e3 to 2118d3f Compare November 19, 2021 01:46

This comment was marked as outdated.

Sign in to view

gustavohenke self-requested a review February 3, 2022 01:21

paescuj added the new feature label May 18, 2022

paescuj changed the title ~~Add auto colors functionality to resolve #279~~ Add auto colors functionality May 20, 2022

paescuj force-pushed the feat/random-colors branch from 2118d3f to fa95ba7 Compare June 21, 2022 09:55

paescuj force-pushed the feat/random-colors branch from fa95ba7 to 77ace98 Compare June 21, 2022 10:05

paescuj self-requested a review June 21, 2022 10:08

paescuj force-pushed the feat/random-colors branch 2 times, most recently from c259335 to f57afd7 Compare June 21, 2022 10:53

gustavohenke reviewed Jun 24, 2022

View reviewed changes

eliasm307 force-pushed the feat/random-colors branch from bc1e427 to efa6cf1 Compare July 22, 2022 14:16

eliasm307 force-pushed the feat/random-colors branch 6 times, most recently from 5bdf259 to 8200972 Compare July 23, 2022 10:10

paescuj approved these changes Jul 24, 2022

View reviewed changes

paescuj requested a review from gustavohenke July 24, 2022 12:55

paescuj force-pushed the feat/random-colors branch from b9063e6 to b549681 Compare August 11, 2022 12:55

add auto colors functionality to resolve open-cli-tools#279

24f1ea8

Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>

eliasm307 and others added 6 commits August 11, 2022 15:37

update prefix color selector to use a generator

8c29b54

Remove leftovers from first solution

27de589

Update docs

f3e6587

Start comments with upper case

2bf1df6

To be consistent with existing code style

Consistent use of 'color'

3376905

Move assertSelectedColors to expect.extend

f3c1fcf

paescuj force-pushed the feat/random-colors branch from b549681 to f3c1fcf Compare August 11, 2022 13:38

paescuj added 4 commits August 12, 2022 09:07

Revert "Move assertSelectedColors to expect.extend"

7025f86

This reverts commit f3c1fcf.

Lint fix (new parens rule)

1a79552

Enhance & register 'assertSelectedColors' as assert function

59e2c64

Use 'each' to handle repetive tests and to get rid of 'assertSelected…

fb6bef0

…Colors' I'm neither happy with extending expect nor with having expect in a external function, so I'm using 'it.each' to solve this

gustavohenke approved these changes Oct 8, 2022

View reviewed changes

src/prefix-color-selector.spec.ts Outdated Show resolved Hide resolved

Clarify comment for ACCEPTABLE_CONSOLE_COLORS test

7929986

paescuj merged commit b56fbdd into open-cli-tools:main Oct 10, 2022

Leo1312424 mentioned this pull request Jul 15, 2024

[Snyk] Upgrade concurrently from 7.5.0 to 7.6.0 Leo1312424/HackMe#4

Open

abdulrahman305 mentioned this pull request Jul 26, 2024

[Snyk] Upgrade concurrently from 7.0.0 to 7.6.0 abdulrahman305/aws-sdk-js-v3#1

Open

mun1013 mentioned this pull request Aug 2, 2024

[Snyk] Upgrade concurrently from 7.0.0 to 7.6.0 mun1013/taxiApp-react-typescript#2

Open

Mark-hub-2323 mentioned this pull request Aug 22, 2024

[Snyk] Upgrade concurrently from 5.3.0 to 8.2.2 Mark-hub-2323/juice-shop#11

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add auto colors functionality #296

Add auto colors functionality #296

eliasm307 commented Nov 19, 2021 •

edited

Loading

coveralls commented Nov 19, 2021 •

edited

Loading

This comment was marked as outdated.

paescuj commented Jun 21, 2022

gustavohenke left a comment •

edited by paescuj

Loading

eliasm307 commented Jun 25, 2022

gustavohenke commented Jun 29, 2022

paescuj commented Jun 30, 2022

eliasm307 commented Jul 22, 2022 •

edited

Loading

eliasm307 commented Jul 22, 2022

paescuj left a comment

paescuj commented Oct 2, 2022

gustavohenke left a comment

gustavohenke commented Oct 22, 2022

Add auto colors functionality #296

Add auto colors functionality #296

Conversation

eliasm307 commented Nov 19, 2021 • edited Loading

coveralls commented Nov 19, 2021 • edited Loading

This comment was marked as outdated.

paescuj commented Jun 21, 2022

gustavohenke left a comment • edited by paescuj Loading

Choose a reason for hiding this comment

eliasm307 commented Jun 25, 2022

gustavohenke commented Jun 29, 2022

paescuj commented Jun 30, 2022

eliasm307 commented Jul 22, 2022 • edited Loading

eliasm307 commented Jul 22, 2022

paescuj left a comment

Choose a reason for hiding this comment

paescuj commented Oct 2, 2022

gustavohenke left a comment

Choose a reason for hiding this comment

gustavohenke commented Oct 22, 2022

eliasm307 commented Nov 19, 2021 •

edited

Loading

coveralls commented Nov 19, 2021 •

edited

Loading

gustavohenke left a comment •

edited by paescuj

Loading

eliasm307 commented Jul 22, 2022 •

edited

Loading