Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows testing improvements #337

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Windows testing improvements #337

merged 1 commit into from
Aug 11, 2022

Conversation

gustavohenke
Copy link
Member

@gustavohenke gustavohenke commented Jul 8, 2022 •
edited by paescuj
Loading

Closes #277

@gustavohenke gustavohenke changed the title Better testing on Windows Windows testing improvements 🤞 Jul 8, 2022
@coveralls
Copy link

coveralls commented Jul 8, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 879dcad on windows into 22f64a1 on main.

@gustavohenke gustavohenke mentioned this pull request Jul 8, 2022
Closed
@paescuj paescuj marked this pull request as ready for review August 3, 2022 10:00
@paescuj paescuj changed the title Windows testing improvements 🤞 Windows testing improvements Aug 3, 2022
@paescuj
Copy link
Collaborator

paescuj commented Aug 3, 2022 •
edited
Loading

It turns out the tests for Windows are working on GitHub because their Windows environment comes with a 'sleep' command preinstalled. However, this is not the case on a default Windows setup.
Therefore I decided to provide own Node.js implementation of the 'sleep' command and use this one in the tests. This (additionally) makes sure we're testing exactly the same on all platforms.

✅ Also tested on a Windows machine!

@paescuj paescuj merged commit bc477a0 into main Aug 11, 2022
@paescuj paescuj deleted the windows branch August 11, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please fix tests to run on windows
3 participants
@gustavohenke @coveralls @paescuj