-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance testing #346
Enhance testing #346
Conversation
Fixing all lint problems in this file
expect(observerSpy.getValueAt(0)).toEqual({ startDate, endDate: undefined }); | ||
expect(observerSpy.getValueAt(1)).toEqual({ startDate, endDate }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice! But it seems it assumes that the observers will emit synchronously... or did I miss anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, you're right! Good catch, thanks! I'm going to address this in the next days...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what do you think about this? => #369 😃
it.each
instead of defining them twiceexpectLinesForProcessStartAndStop
&expectLinesForTimingsTable
methods toexpect.extend
@types/node
to current active LTS version (v16)Generally, it's advised to align types with the Node.js version - since we're targeting multiple Node.js version we pin the types to the current active LTS version
bin/concurrently.spec.ts
with the help of esbuild