-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pnpm #354
Switch to pnpm #354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only downside is that we could probably no longer use np
I've never used, tbh. I think that's a tool that @kimmobrunfeldt likes and documented somewhere 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM I think, is there anything still pending here? 😄
Only the open conversation... I'm going to rebase and merge it afterwards 🚀 |
🤔 it seems pnpm is a pickier than npm when running publish:
(though I might be on a possibly old release of pnpm, and this might have been a bug) |
Hmm you mean because it's not really "unclean" since it's only an untracked file? In that case it might indeed be a bit pickier and also this might have been addressed in a newer pnpm release... |
pnpm feels like a great alternative to
npm
!The only downside is that we could probably no longer usenp
(sindresorhus/np#251) but I'd suggest to automate the release process with a GitHub workflow, anyway.To be merged after #342 (will update the pull request to use pnpm v7 then)