-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add installStrategy for addon and upgrade to v1beta1 #203
base: main
Are you sure you want to change the base?
Add installStrategy for addon and upgrade to v1beta1 #203
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4679786
to
2c5379c
Compare
Signed-off-by: Jian Qiu <jqiu@redhat.com>
2c5379c
to
137e560
Compare
/lgtm |
For now we need to set storage of mca to v1alpha1, otherwise the installNamespace field will be lost Signed-off-by: Jian Qiu <jqiu@redhat.com>
New changes are detected. LGTM label has been removed. |
type ManagedClusterAddOnSpec struct { | ||
// configs is a list of add-on configurations. | ||
// In scenario where the current add-on has its own configurations. | ||
// An empty list means there are no defautl configurations for add-on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An empty list means there are no owned configurations for add-on?
/hold |
// +kubebuilder:default=open-cluster-management-agent-addon | ||
// +kubebuilder:validation:MaxLength=63 | ||
// +kubebuilder:validation:Pattern=^[a-z0-9]([-a-z0-9]*[a-z0-9])?$ | ||
RegistrationNamespace string `json:"registrationNamespace,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if using Namespace directly is better since it is in the RegistrationConfig struct.
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Jian Qiu jqiu@redhat.com