Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 rename placement decision tracker get function #278

Conversation

haoqing0110
Copy link
Member

Summary

Rename Get() to GetClusterChanges() and add function UpdateClusters() to update the existing clusters.

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from deads2k and mdelder September 12, 2023 09:47
@haoqing0110 haoqing0110 changed the title rename placement decision tracker get function 🌱 rename placement decision tracker get function Sep 12, 2023
@haoqing0110
Copy link
Member Author

/assign @qiujian16

// Get updates the tracker's decisionClusters and returns added and deleted cluster names.
func (pdct *PlacementDecisionClustersTracker) Get() (sets.Set[string], sets.Set[string], error) {
// UpdateClusters updates the tracker's decisionClusters.
func (pdct *PlacementDecisionClustersTracker) UpdateClusters() error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will Update or Refresh better?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to refresh, sounds better.

Signed-off-by: haoqing0110 <qhao@redhat.com>
@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ad02e82 into open-cluster-management-io:main Sep 13, 2023
9 checks passed
@haoqing0110 haoqing0110 deleted the br_pdtracker branch September 13, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants