🐛 support update&updateStatus for manifestwork cloudevents client. #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: morvencao The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: morvencao <lcao@redhat.com>
morvencao
force-pushed
the
br_support_update_for_manifestwork_cloudevents_client
branch
from
790241f to
2d2b0d4
Compare
|
/assign @skeeey |
|
@morvencao the newest work-agent in ocm only use patch way to update mw or it's status, this is why we only implement the patch way for the agent mw client :) |
|
/hold |
morvencao
force-pushed
the
br_support_update_for_manifestwork_cloudevents_client
branch
from
d9a05b6 to
803d948
Compare
|
closing this as the new work-agent only needs |
morvencao
deleted the
br_support_update_for_manifestwork_cloudevents_client
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the addition of 'Update' and 'UpdateStatus' functionalities for the manifestwork cloudevents client. These methods are necessary as the work-client implementation will use them, but currently the manifestwork cloudevents client only includes 'Get' and 'Patch'.