✨ Add fields to support switch hub. #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/wip |
xuezhaojun
changed the title
xuezhaojun
changed the title
xuezhaojun
changed the title
xuezhaojun
force-pushed
the
add-boostrapkubeconfigs
branch
from
ccf5987 to
477807e
Compare
xuezhaojun
force-pushed
the
add-boostrapkubeconfigs
branch
from
477807e to
e315de7
Compare
xuezhaojun
changed the title
|
/assign @qiujian16 |
qiujian16
reviewed
Apr 16, 2024
qiujian16
reviewed
Apr 16, 2024
xuezhaojun
force-pushed
the
add-boostrapkubeconfigs
branch
from
e315de7 to
90159c7
Compare
xuezhaojun
commented
Apr 17, 2024
xuezhaojun
force-pushed
the
add-boostrapkubeconfigs
branch
from
90159c7 to
a5ed787
Compare
qiujian16
reviewed
Apr 18, 2024
xuezhaojun
commented
Apr 18, 2024
Signed-off-by: xuezhaojun <zxue@redhat.com>
xuezhaojun
force-pushed
the
add-boostrapkubeconfigs
branch
from
a5ed787 to
020352a
Compare
|
The |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 018915d
into
open-cluster-management-io:main
10 checks passed
xuezhaojun
commented
May 20, 2024
| // SecretNames is a list of secret names. The secrets are in the same namespace where the agent controller runs. | ||
| // +required | ||
| // +kubebuilder:validation:minItems=2 | ||
| SecretNames []string `json:"secretNames"` |
There was a problem hiding this comment.
Changet to a struct with one filed - name, in case in the future we want to add context in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The API changes for open-cluster-management-io/enhancements#104
Related issue(s)
Fixes #