Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Regenerate informers with WithTransform #320

Merged

Conversation

skitt
Copy link
Contributor

@skitt skitt commented Feb 13, 2024

Summary

Since 1.29, Kubernetes supports transforming informers, which is useful to reduce the amount of memory used by the underlying caches. This updates the code generator to the latest 0.29 release and re-generates the informers.

Related issue(s)

Fixes #

@dfarrell07
Copy link

/lgtm

@vthapar
Copy link

vthapar commented Feb 14, 2024

Can we get review on this? This will be very helpful for optimization work we're doing on SubmarinerAddon.

@mikeshng
Copy link
Member

/assign @qiujian16

@qiujian16
Copy link
Member

would you run go mod tidy and go mod vendor?

Since 1.29, Kubernetes supports transforming informers, which is
useful to reduce the amount of memory used by the underlying caches.
This updates the code generator to the latest 0.29 release and
re-generates the informers.

This requires upgrading to Go 1.21.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@skitt skitt force-pushed the transform-informers branch from 8176c97 to 96ca0a5 Compare February 19, 2024 09:55
@skitt
Copy link
Contributor Author

skitt commented Feb 19, 2024

would you run go mod tidy and go mod vendor?

I’d already done that, the verify-deps failure happened because CI was set up for Go 1.20 and the build now requires 1.21.

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 20, 2024
Copy link
Contributor

openshift-ci bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, skitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 29e1b1d into open-cluster-management-io:main Feb 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants