Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 add condition and reason definition in operator #325

Merged

Conversation

zhiweiyin318
Copy link
Member

Summary

move the condition and reason definitions of operator here.

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from deads2k and qiujian16 April 11, 2024 07:14
@zhiweiyin318 zhiweiyin318 force-pushed the add-contants branch 3 times, most recently from 4300319 to 2b62244 Compare April 11, 2024 07:46
operator/v1/types_clustermanager.go Outdated Show resolved Hide resolved
operator/v1/types_clustermanager.go Outdated Show resolved Hide resolved
operator/v1/types_clustermanager.go Outdated Show resolved Hide resolved
operator/v1/types_clustermanager.go Outdated Show resolved Hide resolved
operator/v1/types_clustermanager.go Outdated Show resolved Hide resolved
operator/v1/types_klusterlet.go Outdated Show resolved Hide resolved
operator/v1/types_klusterlet.go Outdated Show resolved Hide resolved
// ReasonManagementClusterResourceApplyFailed is the reason of ConditionKlusterletApplied condition failed to apply resources on management cluster.
ReasonManagementClusterResourceApplyFailed = "ManagementClusterResourceApplyFailed"

// ReasonKlusterletPrepareFailed is the reason of ConditionReadyToApply condition to show failed to prepare before apply/delete resources.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does prepare mean?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prepare means to get kubeconfig in external-managed-kubeconfig secret successfully
changed to :
ReasonKlusterletPrepareFailed is the reason of ConditionReadyToApply condition to show it is failed to get the kubeConfig of managed cluster from the external-managed-kubeconfig secret in the hosted mode.

ReasonKlusterletPrepared is the reason of ConditionReadyToApply condition to show the kubeConfig of managed cluster is validated from the external-managed-kubeconfig secret in the hosted mode.

operator/v1/types_klusterlet.go Outdated Show resolved Hide resolved
operator/v1/types_klusterlet.go Outdated Show resolved Hide resolved
@zhiweiyin318 zhiweiyin318 force-pushed the add-contants branch 3 times, most recently from 7de8ca7 to 46b2dad Compare April 11, 2024 11:53
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8f6aa25 into open-cluster-management-io:main Apr 11, 2024
10 checks passed
@zhiweiyin318 zhiweiyin318 deleted the add-contants branch April 11, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants