Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix objectSelector polling #325

Conversation

dhaiducek
Copy link
Member

The objectSelector was always running in watch mode regardless of the evaluationInterval.

ref: https://issues.redhat.com/browse/ACM-15952

The objectSelector was always running in watch
mode regardless of the evaluationInterval.

ref: https://issues.redhat.com/browse/ACM-15952
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
@dhaiducek dhaiducek force-pushed the 15952-selector-interval branch from 98f0d1b to 6d1ee96 Compare December 17, 2024 01:33
Copy link
Member

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests!

Copy link

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, JustinKuli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JustinKuli,dhaiducek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2fc4924 into open-cluster-management-io:main Dec 17, 2024
13 checks passed
@dhaiducek dhaiducek deleted the 15952-selector-interval branch December 17, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants