upgrade managed serviceaccount api version to v1beta1 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xiangjingli
commented
Jan 8, 2024
xiangjingli
commented
- I have taken backward compatibility into consideration.
- pick up managedServiceAccount api with version v1beta1, v1alpha will be deprecated
- reduce managedServiceAccount api detection frequency to every 5 mins to avoid user confusion. The managedServiceAccount API could never be enabled if users just render cluster secrets with default admin SA. In this case, It is quite annoying for such users to see the managedServiceAccount API is not ready every 10 seconds
Signed-off-by: Xiangjing Li <xiangli@redhat.com>
xiangjingli
requested review from
philipwu08
and removed request for
lennysgarage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
=======================================
Coverage 73.05% 73.05%
=======================================
Files 14 14
Lines 2769 2769
=======================================
Hits 2023 2023
Misses 605 605
Partials 141 141
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikeshng, xiangjingli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.