-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
label selector is no longer supported in ManagedClusterSet #99
Conversation
xiangjingli
commented
May 2, 2024
- I have taken backward compatibility into consideration.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 72.97% 73.26% +0.28%
==========================================
Files 14 14
Lines 2779 2779
==========================================
+ Hits 2028 2036 +8
+ Misses 609 603 -6
+ Partials 142 140 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the examples under https://github.com/open-cluster-management-io/multicloud-integrations/tree/main/examples
needs to be fixed too I think
Signed-off-by: Xiangjing Li <xiangli@redhat.com>
2b8ae9b
to
856f4ff
Compare
@mikeshng The new fix is ready for review. Also the e2e test failure was fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikeshng, xiangjingli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |