Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label selector is no longer supported in ManagedClusterSet #99

Merged
merged 1 commit into from
May 3, 2024

Conversation

xiangjingli
Copy link
Collaborator

  • I have taken backward compatibility into consideration.

@openshift-ci openshift-ci bot requested review from chenz4027 and mikeshng May 2, 2024 21:26
@xiangjingli xiangjingli removed the request for review from chenz4027 May 2, 2024 21:26
@openshift-ci openshift-ci bot added the approved label May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.26%. Comparing base (7462dc4) to head (856f4ff).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   72.97%   73.26%   +0.28%     
==========================================
  Files          14       14              
  Lines        2779     2779              
==========================================
+ Hits         2028     2036       +8     
+ Misses        609      603       -6     
+ Partials      142      140       -2     
Flag Coverage Δ
unit 73.26% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Xiangjing Li <xiangli@redhat.com>
@xiangjingli
Copy link
Collaborator Author

xiangjingli commented May 2, 2024

@mikeshng The new fix is ready for review. Also the e2e test failure was fixed

Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 3, 2024
Copy link

openshift-ci bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikeshng,xiangjingli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d6d5796 into main May 3, 2024
9 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the fixManagedClusterSet branch May 3, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants