Add default controller leader election setting values #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
lennysgarage
force-pushed
the
leader-election
branch
from
c43a21c to
cf662e9
Compare
|
/unhold |
xiangjingli
reviewed
Aug 23, 2022
lennysgarage
force-pushed
the
leader-election
branch
from
cf662e9 to
8152465
Compare
Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> Add controller leader election settings configurability Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> Add leader-election-lease-duration Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> Add leader-election-lease-duration Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com>
lennysgarage
force-pushed
the
leader-election
branch
from
8152465 to
6df64ea
Compare
xiangjingli
approved these changes
Aug 23, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lennysgarage, xiangjingli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
TomerFi
pushed a commit
to TomerFi/multicloud-operators-subscription
that referenced
this pull request
Nov 22, 2022
…anagement-io#242) Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> Add controller leader election settings configurability Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> Add leader-election-lease-duration Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> Add leader-election-lease-duration Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> (cherry picked from commit c389b56)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following recommended default settings of leaseDuration=137s, renewDeadline=107s, and retryPeriod=26s from https://github.com/openshift/library-go/blob/4b9033d00d37b88393f837a88ff541a56fd13621/pkg/config/leaderelection/leaderelection.go#L84
https://github.com/stolostron/backlog/issues/25245
Signed-off-by: Jonathan Marcantonio jmarcant@redhat.com