Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added unit tests for the hub propagation #272

Conversation

TomerFi
Copy link
Member

@TomerFi TomerFi commented Oct 27, 2022

Added unit tests for propagation by the hub, this should increase coverage and help get the sync issue pass.

Issue: https://github.com/stolostron/backlog/issues/25649
Sync-issue: stolostron/multicloud-operators-subscription#862

@openshift-ci openshift-ci bot requested review from jnpacker and rokej October 27, 2022 20:30
@TomerFi TomerFi force-pushed the propagation-unit-tests branch from 5d928af to 75210f6 Compare October 27, 2022 20:46
@TomerFi TomerFi marked this pull request as draft October 28, 2022 05:03
@TomerFi TomerFi force-pushed the propagation-unit-tests branch 7 times, most recently from 7b17a89 to c370dfb Compare October 29, 2022 21:34
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
@TomerFi TomerFi force-pushed the propagation-unit-tests branch from c370dfb to 9c321a5 Compare October 29, 2022 22:18
@TomerFi TomerFi marked this pull request as ready for review October 29, 2022 22:47
Copy link
Collaborator

@chenz4027 chenz4027 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@chenz4027
Copy link
Collaborator

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenz4027, TomerFi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chenz4027
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 31, 2022
@openshift-merge-robot openshift-merge-robot merged commit 370eb8f into open-cluster-management-io:main Oct 31, 2022
@TomerFi TomerFi deleted the propagation-unit-tests branch November 6, 2022 09:14
@TomerFi TomerFi restored the propagation-unit-tests branch November 6, 2022 09:15
TomerFi added a commit to TomerFi/multicloud-operators-subscription that referenced this pull request Nov 22, 2022
…nt-io#272)

Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>

Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
(cherry picked from commit 370eb8f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants