Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance SubscriptionStatus orphans cleanup by implementing increasing… #308

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Conversation

mikeshng
Copy link
Member

@mikeshng mikeshng commented Jan 12, 2023

… the frequency of the cleanup with a cap of 1 hr interval

for https://issues.redhat.com/browse/ACM-2767

Signed-off-by: Mike Ng ming@redhat.com

@openshift-ci openshift-ci bot requested review from jnpacker and rokej January 12, 2023 17:56
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mikeshng mikeshng requested review from xiangjingli and removed request for jnpacker and rokej January 12, 2023 17:56
@mikeshng
Copy link
Member Author

/hold

for more testing.

@xiangjingli I couldn't use the backoff function you recommended because it will terminate (backoff) eventually. I think we need this function to run forever in the background but at the max 1 hr interval as discussed. I couldn't find other wait function that has the cap interval and the backoff unfortunately has the cap but it terminates.

… the frequency of the cleanup with a cap of 1 hr interval

Signed-off-by: Mike Ng <ming@redhat.com>
@mikeshng
Copy link
Member Author

/unhold

I can see from the logs the cleanup is taking place at the pace we want it.

@xiangjingli
Copy link
Collaborator

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants