ACM-4489 disable caching of secrets & service accounts #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lennysgarage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lennysgarage
requested review from
xiangjingli,
mikeshng and
philipwu08
and removed request for
rokej
lennysgarage
commented
Apr 13, 2023
lennysgarage
force-pushed
the
ACM-4489
branch
3 times, most recently
from
a1b0d1b to
19ea056
Compare
Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> Grab only necessary secrets Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> Lint files Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> Disable cache for secrets Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> Replace client with Non-caching client Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> Replace client with non-caching client Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> Revert helmrelease change & disable cache for secrets & serviceaccounts Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com>
lennysgarage
changed the title
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the consistent crashing of the application-manager controller by disabling the caching of Secrets and ServiceAccounts.
Addresses: