Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update leader election settings #330

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

lennysgarage
Copy link
Member

This PR updates the leader election settings and renames the leader election options from

--renew-deadline ==> leader-election-renew-deadline
--retry-period ==> leader-election-retry-period

@openshift-ci openshift-ci bot requested review from jnpacker and philipwu08 April 19, 2023 19:08
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lennysgarage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lennysgarage lennysgarage force-pushed the update-leader-election branch from 72f982d to 566caae Compare April 19, 2023 19:27
Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com>

Add leader election settings to csv & deployment

Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com>

Update int to time.Duration

Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com>
@lennysgarage lennysgarage force-pushed the update-leader-election branch from 566caae to 57b9457 Compare April 19, 2023 19:44
@lennysgarage lennysgarage requested review from chenz4027, xiangjingli and mikeshng and removed request for jnpacker April 19, 2023 20:20
@xiangjingli
Copy link
Collaborator

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants