Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump generator to v1.12.1 #333

Conversation

dhaiducek
Copy link
Member

Pick up a bugfix found during feature verification

Pick up a bugfix found during feature verification

Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
@openshift-ci openshift-ci bot requested review from rokej and xiangjingli May 1, 2023 19:54
Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 1, 2023
@dhaiducek
Copy link
Member Author

Looks like there's a test flake here--I wouldn't think this PR would cause a failure. Could someone try re-running it, please?

• [FAILED] [78.229 seconds]
test create/update/delete appsub status for standalone and managed cluster
/home/runner/work/multicloud-operators-subscription/multicloud-operators-subscription/go/src/github.com/open-cluster-management/multicloud-operators-subscription/pkg/synchronizer/kubernetes/sync_appsubstatus_test.go:181
  [It] Test appsubReports and appsubstatus on standalone and managed cluster
  /home/runner/work/multicloud-operators-subscription/multicloud-operators-subscription/go/src/github.com/open-cluster-management/multicloud-operators-subscription/pkg/synchronizer/kubernetes/sync_appsubstatus_test.go:182

  Expected
      <bool>: false
  to be true
  In [It] at: /home/runner/work/multicloud-operators-subscription/multicloud-operators-subscription/go/src/github.com/open-cluster-management/multicloud-operators-subscription/pkg/synchronizer/kubernetes/sync_appsubstatus_test.go:457
------------------------------


Summarizing 1 Failure:
  [FAIL] test create/update/delete appsub status for standalone and managed cluster [It] Test appsubReports and appsubstatus on standalone and managed cluster
  /home/runner/work/multicloud-operators-subscription/multicloud-operators-subscription/go/src/github.com/open-cluster-management/multicloud-operators-subscription/pkg/synchronizer/kubernetes/sync_appsubstatus_test.go:457

@openshift-merge-robot openshift-merge-robot merged commit 0f86306 into open-cluster-management-io:main May 1, 2023
@dhaiducek dhaiducek deleted the bump-generator branch May 1, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants